CODE RUB: Test Nhs Login Playwright Update#190
Merged
davidhayes03 merged 2 commits intomainfrom Feb 2, 2026
Merged
Conversation
github-actions
bot
added
the
CODE RUB
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Playwright test suite for NHS Login authentication, adds new test cases for the authentication flow, and improves the CI/CD configuration. The changes introduce comprehensive helpers for NHS Login workflows and reorganize test setup files.
Changes:
- Added new Playwright test files for NHS Login authentication setup and homepage testing
- Created helper functions to handle NHS Login credentials, OTP verification, and device remembering
- Fixed environment variable formatting in GitHub Actions workflow
- Added a new folder structure reference in the project file
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| auth.setup.tffs | New authentication setup file for persisting NHS Login session state |
| homepageNhsLogin.spec.ts | New test suite covering NHS Login flow and user detail verification |
| helper.ts | Extended with NHS Login credential handling and OTP management functions |
| LondonDataServices.IDecide.Portal.Client.esproj | Added reference to new test setup folder structure |
| build.yml | Fixed indentation of environment variables from incorrect nesting to proper YAML format |
LondonDataServices.IDecide.Portal.Client/LondonDataServices.IDecide.Portal.Client.esproj
Show resolved
Hide resolved
davidhayes03
deleted the
users/davidhayes03/code-rub-playwright-updates
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes AB#27411